-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update minimum TypeScript version to 3.2 #21197
Conversation
Details of bundle changes.Comparing: 23cc516...0c1023f Details of page changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me whether the example now requires 3.2 as opposed to 2.8 or if @material-ui/core
requires 3.2 (up from 2.8). We might want to mention the CRA demo later.
With regards to the supported version in v5: We're probably going to align with DefinitelyTyped on release which means 3.2 or 3.3: https://github.com/DefinitelyTyped/DefinitelyTyped/#older-versions-of-typescript-28-and-earlier
Do you have suggestions on how it can be reworded?
|
Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com>
@NMinhNguyen Thanks! |
We might want to consider bumping the minimum version in MUI v5 again because https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0 no longer supports TypeScript 3.2. It would also allow us to use trailing commas for better diffs and revert #20443