-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accordion] Add new classes key #21920
[Accordion] Add new classes key #21920
Conversation
@oliviertassinari Should I be changing both the .js file and .tsx file with the changes? |
@natac13 Run yarn docs:api |
This comment has been minimized.
This comment has been minimized.
5ec2167
to
0ebbadf
Compare
@natac13 Well done |
Could somebody elaborate why Collapse was also changed and why the region class was added? This is not apparent from the conversation in this PR or the linked issue. |
@eps1lon The region class was added so all DOM nodes can be targeted in the document. Collapse was changed to fix one inconsistency in the naming. |
Why was this part of this PR? |
It was part of this PR to improve the customization story, the topic of the linked issue. It's a small inconsistency we didn't catch sooner (all elements should be customizable), following the boy scouts rule: leaving the forest cleaner than we found it :) |
Breaking change
The
classes.container
key was changed to match the convention of the other components.closes #21723