Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making clickaway more logical #2346

Closed
wants to merge 1 commit into from
Closed

Conversation

chrismcv
Copy link
Contributor

@chrismcv chrismcv commented Dec 2, 2015

@oliviertassinari - this fixes your animation issue with nested menus

@oliviertassinari
Copy link
Member

I may have another approach to solve the issue.
I think that it would be better to add an onRequestClose property
to the Popover component to make it "controllable" as we are doing with the Dialog
or the LeftNav.
This approach would probably save us from using a ref.

@oliviertassinari
Copy link
Member

I think that it would be better to add an onRequestClose property

Edit: this property already exist and wasn't working as expected IMHO.
This is an attempt to improve it #2353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ClickAwayListener The React component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants