layer clickaway option for render-to-layer/popover

[chrismcv]

@oliviertassinari - ended up changing the property name to useLayerForClickAway

[oliviertassinari]

How can I test this?

[chrismcv]

So on icon menu/menu - you can still click underlying elements, because they pass in false to the new prop.

On Popover, it doesn't, so if you click on the left nav, it will now close the popover rather than trigger a navigation.

[oliviertassinari]

20 seems to be a magic number

[chrismcv]

it matches zIndex of Popover L#124 - what do you want to do with it?

[chrismcv]

zIndex of 0 works, so now using this

[oliviertassinari]

What should we do for https://github.com/callemall/material-ui/blob/master/src/dialog.jsx#L458?
Maybe adding useLayerForClickAway={false}?

[oliviertassinari]

@chrismcv I like this new property 👍.

[chrismcv]

@oliviertassinari - this should be good now?

[oliviertassinari]

What should we do with the Dialog component? We have kind of a duplicated logic for the clickAway.

[chrismcv]

Because it uses Overlay, I think this should probably remain as is - as the Overlay is on top of the _layer, so will have click precedence.

[chrismcv]

@oliviertassinari new commit with zIndex on theme

[oliviertassinari]

Shouldn't we use layerZIndex?

[chrismcv]

@oliviertassinari - this looks good now

[oliviertassinari]

@chrismcv Looks good 👍. Could you squash down? I will merge 😄.

[chrismcv]

@oliviertassinari 👍

[oliviertassinari]

Thanks

[chrismcv]

and you @oliviertassinari

[niba]

@oliviertassinari @chrismcv
There are two errors in code.

1. Documentation says that default: false which is incorrect. The default is true.
2. You dont pass useLayerForClickAway from popup to render layer.

[oliviertassinari]

You are right on both points.
Can you open an issue?