Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip] Fix focus-visible regression #24906

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 13, 2021

The regression comes indirectly from #22430. You can experience it in the documentation. For instance, the chips of https://next.material-ui.com/components/alert/ (WAI-ARIA, Figma, etc.) have no visual indicator when keyboard focused.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: chip This is the name of the generic UI component, not the React module! labels Feb 13, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 13, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 9028f99

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@oliviertassinari oliviertassinari merged commit 9412964 into mui:next Feb 15, 2021
@oliviertassinari oliviertassinari deleted the chip-fix-focus-visible branch February 15, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work component: chip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants