[Pickers] Fix picker components not opening on click in React 17 #24981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
force-pushed
the
fix/pickers/clickaway-react17
branch
from
86dc2b6 to
445b402
Compare
eps1lon
force-pushed
the
fix/pickers/clickaway-react17
branch
from
445b402 to
e21c758
Compare
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24874
We're hitting facebook/react#20074 again.
Trying a different fix than the one in ClickAwayListener. In the lab we can experiment a bit more. Getting rid of the timers would make this logic easier to follow
I think I didn't fully grasp the implications of that bug since I thought facebook/react#20074 only had implications for components inside a Portal. But that's not true since it'll flush all effects in a React root (all roots?) not just in a particular subtree of a component.
Test plan