[core] Allow running full pipeline with various React versions #25005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
core/react-dist-tag-pipeline
branch
from
cd5f5d3
to
b6f709b
Compare
eps1lon
force-pushed
the
core/react-dist-tag-pipeline
branch
from
2080ceb
to
a3ad23e
Compare
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
Disregard the failing checks. THe head commit is green: https://app.circleci.com/pipelines/github/mui-org/material-ui/38302/workflows/cf64b207-0001-4884-af59-4287508fcf7d. I just accidentally triggered a CI run with |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from a git-based branching for different React versions to feature flags (leveraging
React.version).Maintaining the patch is too brittle and takes too much time.
React.versionis now generally available so we can use that instead.This will make it easier to test PRs (or branches) with different versions by just using the CircleCI API (PR includes documentation for that) instead of having to manually enable it (like
d2dd1e7(#23367)).Note that any job relying on
git diff --exit-codepassing will still fail (e.gtest_static). I'd like to change that but it's not trivial to do so I'm not working on it until we need it.codecov report (note the
stableandnextbuild i.e. we now get coverage reports for each React version): https://app.circleci.com/pipelines/github/mui-org/material-ui/38302/workflows/e392909e-48a1-4b9f-b498-b37b6cda44d1pipelineworkflow triggered via API (body:{"branch":"pull/25005/merge","parameters":{"react-dist-tag":"next","workflow":"pipeline"}}): https://app.circleci.com/pipelines/github/mui-org/material-ui/38303/workflows/a50f8937-c4a3-4a6c-bfac-38c83ed0a4e5