Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Migrate Grid demos to emotion #25332

Merged
merged 17 commits into from
Mar 14, 2021
Merged

[docs] Migrate Grid demos to emotion #25332

merged 17 commits into from
Mar 14, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Mar 13, 2021

The following demos of the Grid component were migrated:

  • Spacing
  • Basic grid
  • Grid whit multiple breakpoint
  • Auto Layout
  • Complex Grid
  • Nested Grid
  • Limitations: white-space: nowrap;
  • Interactive Grid
  • CSS Grid

Related to #16947

@vicasas vicasas changed the title Feature/migrate grid demo to emotion [docs] Migrate Grid to emotion Mar 13, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 13, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 1af5f0e

@vicasas
Copy link
Member Author

vicasas commented Mar 13, 2021

For the demos that use Paper component could be used the api styled? thinking of little demos

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 13, 2021 •
edited
Loading

For the demos that use Paper component could be used the api styled? thinking of little demos

@vicasas Yes please, but only where it can be effective. For instance, I have given it a try in 443a7a3. It's much better. Compare:

Screenshot 2021-03-14 at 00 10 33

Screenshot 2021-03-14 at 00 10 43

@oliviertassinari oliviertassinari added component: Grid The React component. docs Improvements or additions to the documentation labels Mar 13, 2021
@github-actions github-actions bot mentioned this pull request Mar 13, 2021
Closed
@oliviertassinari oliviertassinari merged commit f7a8681 into mui:next Mar 14, 2021
@oliviertassinari
Copy link
Member

@vicasas Great

@vicasas vicasas changed the title [docs] Migrate Grid to emotion [docs] Migrate Grid demos to emotion Mar 14, 2021
@vicasas vicasas mentioned this pull request Mar 15, 2021
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: Grid The React component. docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicasas @mui-pr-bot @oliviertassinari