Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES6] Use module everywhere #2614

Merged
merged 1 commit into from
Dec 21, 2015
Merged

[ES6] Use module everywhere #2614

merged 1 commit into from
Dec 21, 2015

Conversation

oliviertassinari
Copy link
Member

Fix #2558.

@@ -1,78 +1,226 @@
import AppBar from './app-bar';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can get the babel 6 in with the state 1 preset, we can use the export extensions to simplifiy this.

All of them can be like:

export  {AppBar} from './app-bar';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to know.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I see that 1 line export is not considered a good practice. https://github.com/airbnb/javascript#10.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are bad for files that perform logic, true. but for files that the only thing they do is re-export i think it makes sense. without this syntax the number of lines become excessively large and hard to maintain.

@alitaheri
Copy link
Member

@newoga Yeah, but babel 6 proved too difficult apparently, for now this is good enough.

oliviertassinari added a commit that referenced this pull request Dec 21, 2015
@oliviertassinari oliviertassinari merged commit ee38312 into mui:master Dec 21, 2015
@alitaheri
Copy link
Member

Thanks 🎉 👍

@oliviertassinari oliviertassinari deleted the ES6-module branch December 21, 2015 12:43
@zannager zannager added the package: system Specific to @mui/system label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the code base to ES6 module
5 participants