-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES6] Use module everywhere #2614
Conversation
@@ -1,78 +1,226 @@ | |||
import AppBar from './app-bar'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can get the babel 6 in with the state 1 preset, we can use the export extensions to simplifiy this.
All of them can be like:
export {AppBar} from './app-bar';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good to know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I see that 1 line export is not considered a good practice. https://github.com/airbnb/javascript#10.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are bad for files that perform logic, true. but for files that the only thing they do is re-export i think it makes sense. without this syntax the number of lines become excessively large and hard to maintain.
@newoga Yeah, but babel 6 proved too difficult apparently, for now this is good enough. |
[ES6] Use module everywhere
Thanks 🎉 👍 |
Fix #2558.