Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Use a single LeftNav #2721

Merged
merged 1 commit into from
Dec 30, 2015
Merged

[Docs] Use a single LeftNav #2721

merged 1 commit into from
Dec 30, 2015

Conversation

oliviertassinari
Copy link
Member

Fix more points of #2435 proposed by @newoga.
dec 30 2015 14 09
Notice that there is twice as much code deleted as code added 🎉.

@Zadielerick Once this PR is merged, subsection of component like an Icon one can be added easily.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: Needs Review labels Dec 30, 2015
@alitaheri
Copy link
Member

Wow this is awesome! 👍 👍 🎉 🎈 🎄 🎉

@alitaheri
Copy link
Member

I love it 😍 Feel free to merge 👍 👍

oliviertassinari added a commit that referenced this pull request Dec 30, 2015
@oliviertassinari oliviertassinari merged commit 947ad7d into mui:master Dec 30, 2015
@oliviertassinari oliviertassinari deleted the docs-single-left-nav branch December 30, 2015 14:05
@mbrookes
Copy link
Member

It looks like when the Nav opens responsively it first appears in front of the AppBar, then pops behind it. Can that be avoided?

@oliviertassinari
Copy link
Member Author

Can that be avoided?

I'm gonna investigate

@oliviertassinari
Copy link
Member Author

@mbrookes good catch #2730.

@newoga
Copy link
Contributor

newoga commented Dec 30, 2015

@oliviertassinari Whoa, that's awesome. Looking forward to seeing this!

@mbrookes
Copy link
Member

@oliviertassinari 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants