[Docs] Update Documentation for Menus #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zadielerick Wow, you are unstoppable 😄 |
oliviertassinari
added
docs
|
|
||
| const arrow = ( | ||
| <ArrowDropRight /> | ||
| ); |
There was a problem hiding this comment.
We can leave the <ArrowDropRight /> component here or move it to the render function.
I don't know what's best. There is no performance implication either way.
@alitaheri Though?
Zadielerick
force-pushed
the
menusDocsUpdate
branch
2 times, most recently
from
609f6da
to
bbeac09
Compare
| autoWidth: React.PropTypes.bool, | ||
|
|
||
| /** | ||
| * |
Zadielerick
force-pushed
the
menusDocsUpdate
branch
from
bbeac09
to
4fb7c31
Compare
29 tasks
| @@ -17,27 +17,80 @@ const nestedMenuStyle = { | |||
| const MenuItem = React.createClass({ | |||
|
|
|||
| propTypes: { | |||
| /** | |||
| * If true, a left check mark will be rendered | |||
oliviertassinari
added
PR: needs revision
Zadielerick
force-pushed
the
menusDocsUpdate
branch
3 times, most recently
from
03d474b
to
4bb285f
Compare
| <MenuExampleNested /> | ||
| </CodeExample> | ||
| <PropTypeDescription code={menuCode}/> | ||
| <PropTypeDescription code={menuItemCode}/> |
There was a problem hiding this comment.
Can we add a header="### MenuItem Properties"?
Zadielerick
force-pushed
the
menusDocsUpdate
branch
from
4bb285f
to
c2a1475
Compare
oliviertassinari
added
PR: Review Accepted
and removed
PR: needs revision
oliviertassinari
added a commit
that referenced
this pull request
Jan 8, 2016
[Docs] Update Documentation for Menus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.