[DatePicker] onChange event should be onChangeDate #3168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneZ
changed the title
oliviertassinari
added
the
PR: needs revision
|
Could you update the PR to follow #2957 ? |
|
DatePicker already follows #2957. |
|
@EugeneZ what's your use case with this PR? |
|
I was trying to figure out why DatePicker was passing a null argument to the handler. My search led me to #441, which contained a proposed solution, which I implemented. #2957 makes a lot of sense, too -- at least then every callback in the library will be consistent, even if it means null events. Can you please close #441, since #2957 deprecates the solution discussed there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with regards to #441