Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nesting in Raised/Flat Buttons #323

Merged
merged 4 commits into from Feb 11, 2015
Merged

Allow nesting in Raised/Flat Buttons #323

merged 4 commits into from Feb 11, 2015

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2015

Allows for user to pass down children as opposed to a label to allow for things like creating a material-ui input type='file' and Icon + Text buttons (issue #189). Label or children are required - however, will not accept both. Instead, the children should include the label element or something thereof. This will give the user more control over the button components. Updated docs with examples as well.

It should be noted that in the case of nested elements - the user is responsible for all stylings (ie - all stylings in examples of nested children are not referenced in mui-src. So, if a user wanted to take the input type='file' example, they would want to copy over the stylings in the buttons.less on the docs site.)

hai-cea pushed a commit that referenced this pull request Feb 11, 2015
Allow nesting in Raised/Flat Buttons
@hai-cea hai-cea merged commit 0770cad into mui:master Feb 11, 2015
@hai-cea
Copy link
Member

hai-cea commented Feb 11, 2015

Thanks @gabdallah222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant