[SliderUnstyled] Fix disabledSwap not being respected in onChangeCommitted
#32647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelsycamore
changed the title
move: true to getFingerNewValue to get previousIndex for activeIndex
samuelsycamore
added
package: base-ui
mnajdova
requested changes
May 18, 2022
…en Slider is with disableSwap
mnajdova
reviewed
May 19, 2022
mnajdova
approved these changes
May 19, 2022
mnajdova
changed the title
move: true to getFingerNewValue to get previousIndex for activeIndexdisabledSwap not being respected in onChangeCommitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32381
Added
move: trueon getFingerNewValue in handleTouchEnd. Because at the 'touchEnd' the value is moved and we want to get 'previousIndex' for activeIndex. Not the 'closest'. (lines 418-422).