-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Create the docs theme once #34954
Conversation
5e4b4ea
to
b85ea74
Compare
'Ubuntu Mono', | ||
'monospace', | ||
].join(','), | ||
fontFamilyCode: ['Consolas', 'Monaco', 'Andale Mono', 'Ubuntu Mono', 'monospace'].join(','), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync with docs/public/static/styles/prism-okaidia.css
font family.
|
@bharatkashyap Shall we do this in Toolpad as well? @oliviertassinari (off-topic), we greatly simplified the theme switching logic in Toolpad using our |
@Janpot I think for Jun to explore, we have a bug right now: #33545 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No need to create the same theme over and over again between each
BrandingProvider
instance. In the Joy UI pages, we mount this component a lot of times which can lead to a lot of console.log when you try to debug it.Off-topic it seems that there are way too many ThemeProvider used in the pages, but it's a different problem, so I'm not looking into it. I think that what we need is:
_app
)