Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init soure new tabs #3770

Closed
wants to merge 2 commits into from
Closed

Init soure new tabs #3770

wants to merge 2 commits into from

Conversation

und3fined
Copy link

Please add New Tabs.
New Tabs support large tab item.
export Utils, Styles

This is my first pull request. I look forward to your support if something goes wrong.

Cuong Le added 2 commits March 23, 2016 11:11
Cannot read property 'iconHoverColor' of undefined
@mbrookes mbrookes added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Mar 23, 2016
@mbrookes
Copy link
Member

Thanks for contributing, but changing the tab style in an open source project is unlikely to be something you'll get accepted anywhere.

@mbrookes mbrookes closed this Mar 23, 2016
@und3fined
Copy link
Author

@mbrookes: Thanks for your reply.
I want to contribute source code is Tabs Component. If I change the code style (from tab to space), then pull my request will be accepted?
I look forward to your help.

Thanks

@mbrookes
Copy link
Member

I want to contribute source code is Tabs Component.

Ah, sorry, didn't realised you'd submitted any new code!

If I change the code style (from tab to space), then pull my request will be accepted?

That depends on what your proposed change does, and whether it is something we want to include (as well as code quality and style).

There is some other work underway on Tabs, so I'd suggest opening an issue to discuss your proposed changes before doing any more work.

@und3fined
Copy link
Author

Thanks :)

I found a comment and it seems to be what I did 2861#issuecomment-196667244 . So you can ignore this issue.

I will wait until v0.15 officially released

@und3fined und3fined deleted the new-tabs branch May 27, 2016 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants