[AutoComplete] Fix the regressions

[oliviertassinari]

Closes #3854.

[oliviertassinari]

There is nothing to review, the fixes are really simple.

[mbrookes]

There is nothing to review

Yes there is. 😄

This changes the signature of getStyles(). The rest of the components have getStyles(props, context, state).

[oliviertassinari]

Oh, I have merged too quickly 😱.
Shouldn't this be this opposite? Eg, the spec of shouldComponentUpdate is (nextProps, nextState, nextContext).

[mbrookes]

So what happened is:

Originally the components had getStyles(props, state).

When we removed the default theme, it became getStyles(props, context)

This was enough for most components, but some needed state in getMuiTheme() for other state than muiTheme, so state got appended togetMuiTheme()`s arguments only for those components.

Now that you point it out, it would make sense to follow shouldComponentUpdate() etc, but it will mean passing this.state into getStyles() many times where it isn't needed (if that matters).

[oliviertassinari]

I think that consistency is more important, I have submitted a new PR to follow the code base 👍.

Now that you point it out, it would make sense to follow shouldComponentUpdate() etc, but it will mean passing this.state into getStyles() many times where it isn't needed (if that matters).

I had this concern too. In our specific case, we will be passing the context while we will not use it.

[mbrookes]

In our specific case, we will be passing the context while we will not use it.

This is also true, but I believe such cases are the minority.