Add initialSelectedIndex property to Tabs #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mui#375. Also checks whether the index is not out of bounds w.r.t. the amount of tab children.
|
@WRidder Can you please also add PropType validation as well? Also, please add the prop to the docs here: Thanks! |
|
Alright, updated proptype validation. I also added the proptype validation for tabWidth since it was specified in the docs already. Added initialSelectedIndex to the docs as well. |
hai-cea
pushed a commit
that referenced
this pull request
Mar 11, 2015
Add initialSelectedIndex property to Tabs
|
Thanks @WRidder 👍 |
|
Uf thanks for this one, very convenient specially for routing when sending a direct link to somebody. Any idea when this will be released? |
|
Hopefully we can get v0.7.2 ironed out by Wednesday at the latest. |
zannager
added
the
component: tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375. Also checks whether the index is not out of bounds w.r.t. the amount of tab children.