-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Checkbox][Radio] Fix theme style overrides not working for different sizes #39377
Conversation
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-39377--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for both the Checkbox and Radio components. You can refer to this as an example: link.
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@ZeeshanTamboli We have added the tests. Thanks for pointing that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Left a few comments.
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitstart I made one change. Now it looks good. 👍 Thanks!
Description
Add missing override size styles to Checkbox and Radio components.
Closes #39303
Before: https://codesandbox.io/s/zen-vaughan-882wlf?file=/src/App.tsx
After: https://codesandbox.io/s/angry-agnesi-vw85h6
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.