-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigment-css][nextjs] Allow usage of url() CSS function #41758
Conversation
Netlify deploy previewhttps://deploy-preview-41758--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, just missing tests for the util.
52393b4
to
f7c98a0
Compare
f7c98a0
to
2d88612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great work!
I assume that this PR will work with image import as well, right? given that the framework will replace the image with a string. import image from '../../path/to/image';
<body
className={css`background: url(${image});`}
/> |
True |
in styled/css definitions. This change goes a step further and allows you to reference files using configured aliases that you can't do in plain CSS files in Next.js
cd3d4ca
to
dc6ed93
Compare
in styled/css definitions. This change goes a step further and allows you to reference files using configured aliases that you can't do in plain CSS files in Next.js