Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Fine-tune the OG card image design #41862

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[docs-infra] Fine-tune the OG card image design #41862

merged 1 commit into from
Apr 16, 2024

Conversation

danilo-leal
Copy link
Contributor

Really just tiny tweaks. This is how it is supposed to be now: https://stackblitz.com/edit/vitejs-vite-ukeejd?file=src/App.tsx

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Apr 11, 2024
@danilo-leal danilo-leal self-assigned this Apr 11, 2024
@mui-bot
Copy link

mui-bot commented Apr 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41862--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2e27233

@alexfauquette
Copy link
Member

alexfauquette commented Apr 12, 2024 •
edited by danilo-leal
Loading

Preview: https://deploy-preview-41862--material-ui.netlify.app/edge-functions/og-image?product=Material%20UI&title=Overview&description=Material%20UI%20is%20an%20open-source%20React%20component%20library%20that%20implements%20Google%27s%20Material%20Design.%20It%27s%20comprehensive%20and%20can%20be%20used%20in%20production%20out%20of%20the%20box.

Before After
image image

zanivan
zanivan approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@danilo-leal danilo-leal merged commit e648a5a into mui:next Apr 16, 2024
21 checks passed
@danilo-leal danilo-leal deleted the fine-tune-OG-card-design branch April 16, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@danilo-leal danilo-leal

Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danilo-leal @mui-bot @alexfauquette @zanivan