[docs-infra] Fix flex-shrink pro-plan #41990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
docs-infra-fix-side-nav-shrink
branch
from
127dc97
to
bb3b48f
Compare
Netlify deploy previewhttps://deploy-preview-41990--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
docs-infra-fix-side-nav-shrink
branch
from
bb3b48f
to
edf9882
Compare
oliviertassinari
force-pushed
the
docs-infra-fix-side-nav-shrink
branch
from
edf9882
to
ec681dd
Compare
danilo-leal
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Looks good!
I'm unclear if we need both "Beta" and "Preview", it feels a bit like the same thing. I would remove Beta.
I added "Beta" in light of the Figma plugin's doc living in the Material UI doc space. "Preview" didn't make a lot of sense in the context of a plugin that is in beta. I can absolutely see how they could be interchangeable, but I'm not sure we'd use "Beta" for components and "Preview" for anything else but components.
|
Alright, fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed this small bug on the API pages of MUI X.
Before: https://mui.com/x/api/date-pickers/multi-input-date-time-range-field/
After: https://deploy-preview-41990--material-ui.netlify.app/experiments/docs/og-card/
I have also used the opportunity to improve https://master--material-ui.netlify.app/experiments/docs/og-card/ by isolating what's docs for docs-infra and test for sidenav, and by having more tests for sidenav. It looks like this now:
I'm unclear if we need both "Beta" and "Preview", it feels a bit like the same thing. I would remove Beta.