[core] Fix a few more key spread issues #42168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-42168--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
force-pushed
the
react-18.3.0-key
branch
from
835a59c
to
531c9bb
Compare
oliviertassinari
commented
May 9, 2024
| ) => React.HTMLAttributes<HTMLLIElement>; | ||
| ) => React.HTMLAttributes<HTMLLIElement> & { key: any }; |
There was a problem hiding this comment.
To propagate in Base UI, no?
There was a problem hiding this comment.
would & {key: Key} have been more appropriate here?
The introduction of this any is causing me linter problems when trying to use the same pattern in my code and pass the key explicitly in renderOption.
Comment on lines
627
to
632
| // Need to clearly apply key because of https://github.com/vercel/next.js/issues/55642 | ||
| const { key, ...otherProps } = props2; | ||
| return ( | ||
| <li {...props2} key={props2.key}> | ||
| <li key={key} {...otherProps}> | ||
| {getOptionLabel(option)} | ||
| </li> |
There was a problem hiding this comment.
Revert #40968 because of #39833 (comment).
oliviertassinari
added
the
needs cherry-pick
oliviertassinari
force-pushed
the
react-18.3.0-key
branch
from
531c9bb
to
be5dfd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick iteration on #39833.
There are a lot more issues that I didn't fix. We will need to cherry-pick to
master.