[Grid] Fix support for CSS variables #42574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-42574--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
commented
Jun 8, 2024
Comment on lines
-28
to
-34
| function getOffset(val) { | ||
| const parse = parseFloat(val); | ||
| if (Number.isNaN(parse)) { | ||
| return val; | ||
| } | ||
| return `${parse}${String(val).replace(String(parse), '') || 'px'}`; | ||
| } |
There was a problem hiding this comment.
I believe we can drop this since we have this new constraint: https://mui.com/material-ui/migration/v5-style-changes/#%E2%9C%85-remove-px-suffix.
It seems impossible to have values without units:
, so calc will always work.
1 task
oliviertassinari
force-pushed
the
fix-grid-regression
branch
from
147b14a to
1f84b37
Compare
oliviertassinari
commented
Jun 8, 2024
| @@ -155,6 +155,36 @@ describe('system spacing', () => { | |||
| expect(output).to.deep.equal({ padding: '-2em' }); | |||
| }); | |||
|
|
|||
| it('should support CSS variables single value', () => { | |||
There was a problem hiding this comment.
I feel these tests were missing a bit from #40224. There are present, but higher up in the abstraction chain. Not that important though;
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Grid is broken when using CSS variables, the regression was introduced in #40224 (visible on the description of that PR).
Before
-calc(doesn't workhttps://next--material-ui.netlify.app/core/
After
https://deploy-preview-42574--material-ui.netlify.app/core/
Now, I imagine that during v6 lifecycle we will deprecate https://mui.com/material-ui/react-grid/ for https://mui.com/material-ui/react-grid2/. But first, we will need to migrate all our marketing pages to use the new grid. And even once we do, the deprecated version should continue to work with CSS variables so developers can migrate to it.