[docs] Recommend setting HTML attribute instead of DOM property for RTL #42599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
docs
aarongarciah
changed the title
Netlify deploy preview
Bundle size report |
There was a problem hiding this comment.
Some more reading:
- It is unclear how directionality should be inherited into Shadow DOM whatwg/html#3699 (comment)
- https://developer.mozilla.org/en-US/docs/Web/CSS/direction and why the warning: Add warning to CSS direction page mdn/content#26835
- https://drafts.csswg.org/css-writing-modes-3/#direction
It's a lot more verbose though, so happy either way (with or without this change).
docs/data/material/customization/right-to-left/right-to-left.md
Outdated
Show resolved
Hide resolved
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs on how to set
dir="rtl". Recommend using an HTML attribute instead of using a DOM property. This seems more correct per https://jakearchibald.com/2024/attributes-vs-properties.Suggested by @oliviertassinari in #42566 (comment).