Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Polish out data table demo #43072

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Jul 25, 2024

Found some issues earlier today with some DataGrid demos, and fixed it in Material UI. Basically changed the demo container and added overflow:'clip' to fix the cropped corners.

👉 https://deploy-preview-43072--material-ui.netlify.app/material-ui/react-table/#data-table

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer labels Jul 25, 2024
@zanivan zanivan self-assigned this Jul 25, 2024
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left a question.

The before/after of the changes:

Screenshot 2024-07-26 at 10 06 53 Screenshot 2024-07-26 at 10 07 03

docs/data/material/components/table/table.md Show resolved Hide resolved
@zanivan zanivan merged commit e8a2ef7 into next Jul 26, 2024
29 checks passed
@zanivan zanivan deleted the data-table-demo branch July 26, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants