Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Replace deprecated <ListItem button/> with ListItemButton component in routing libraries list example #43110

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[docs][material-ui] Replace deprecated <ListItem button/> with ListItemButton component in routing libraries list example #43110

merged 3 commits into from
Jul 30, 2024

Conversation

aliharis99
Copy link
Contributor

@aliharis99 aliharis99 commented Jul 29, 2024 •
edited by ZeeshanTamboli
Loading

Closes #43040

@mui-bot
Copy link

mui-bot commented Jul 29, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43110--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 208575f

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: list This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jul 30, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title refactor: Changed <ListItem> with <ListItemButton> for js and tsx files [docs][material-ui] Replace deprecated <ListItem button/> with ListItemButton component in routing libraries list example Jul 30, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Jul 30, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliharis99 Thanks for the pull request. I made the necessary changes.

@ZeeshanTamboli ZeeshanTamboli merged commit da843aa into mui:next Jul 30, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
@aliharis99 @ZeeshanTamboli @web-flow
[docs][material-ui] Replace deprecated <ListItem button/> with `Lis…
b9575bb 
…tItemButton` component in routing libraries list example (#43110)

Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
@aliharis99
Copy link
Contributor Author

Thank you @ZeeshanTamboli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs][material-ui] Routing Libraries List example contains deprecated button prop
3 participants
@aliharis99 @mui-bot @ZeeshanTamboli