Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod] Fix codemod crash on MuiDivider property #43125

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 31, 2024

Closes #43109

Avoid accessing non-existing properties in the @mui/codemod.

@mui-bot
Copy link

mui-bot commented Jul 31, 2024

Netlify deploy preview

https://deploy-preview-43125--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 04b8ae0

@Janpot Janpot added package: codemod Specific to @mui/codemod core Infrastructure work going on behind the scenes labels Jul 31, 2024
@Janpot Janpot changed the title [core] Fix codemod crash on MuiDivider property [codemod] Fix codemod crash on MuiDivider property Jul 31, 2024
@Janpot Janpot marked this pull request as ready for review July 31, 2024 06:57
@zannager zannager requested a review from DiegoAndai July 31, 2024 13:28
@DiegoAndai
Copy link
Member

Hey @Janpot, thanks for the report and PR. I pushed a refactor to use the findComponentDefaultProps util, let me know what you think.

@Janpot
Copy link
Member Author

Janpot commented Aug 1, 2024

Looks good 👍

@DiegoAndai DiegoAndai merged commit 0ed7c11 into mui:next Aug 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes package: codemod Specific to @mui/codemod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codemod errors on object containing MuiDivider property
3 participants