Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod] Skip ListItemButton import for unrelated files #43532

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

siriwatknp
Copy link
Member

closes #43527

@siriwatknp siriwatknp added package: codemod Specific to @mui/codemod v6.x labels Aug 30, 2024
@mui-bot
Copy link

mui-bot commented Aug 30, 2024

Netlify deploy preview

https://deploy-preview-43532--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against cee2d52

@DiegoAndai
Copy link
Member

@siriwatknp I refactored to cover the following case:

import ListItem from '@mui/material/ListItem';

// ...

<>
  <ListItem />
  <ListItem button />
</>

In which there are no imports to remove but we still need to add the ListItemButton one.

@DiegoAndai DiegoAndai merged commit e57669d into mui:master Sep 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: codemod Specific to @mui/codemod v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list-item-button-prop codemod adds ListItemButton import to all files
3 participants