Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Fix crashing of DraggableDialog demo #44811

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 19, 2024

@sai6855 sai6855 added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse labels Dec 19, 2024
@mui-bot
Copy link

mui-bot commented Dec 19, 2024

Netlify deploy preview

https://deploy-preview-44811--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8f39c8b

@sai6855
Copy link
Contributor Author

sai6855 commented Dec 19, 2024

@aarongarciah do you have any insight on why ci/circleci: test_e2e is failing?

@aarongarciah
Copy link
Member

aarongarciah commented Dec 19, 2024

@sai6855 it's probably related to the UMD build. @DiegoAndai pinned the UMD versions on the example being used in the test:umd script. See #44706.

The error is not the same though:

I'm clueless on why this started to fail now.

@zannager zannager requested a review from siriwatknp December 19, 2024 10:43
@DiegoAndai DiegoAndai requested review from DiegoAndai and removed request for siriwatknp December 19, 2024 12:35
@DiegoAndai
Copy link
Member

Looking into it

@DiegoAndai
Copy link
Member

DiegoAndai commented Dec 19, 2024

The reason is that after bumping React 19, we're trying to build the UMD files using React 19, which isn't supported. I'm working on a solution to rely on React 18 only for the UMD build process.

@DiegoAndai
Copy link
Member

Opened a PR to fix it: #44815

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 24, 2024
@DiegoAndai
Copy link
Member

@sai6855 the fix has been merged, please re-run the CI

@aarongarciah aarongarciah changed the title [material-ui][Dialog] Fix crashing of DraggableDialog demo [docs][material-ui] Fix crashing of DraggableDialog demo Dec 24, 2024
@aarongarciah aarongarciah merged commit 0f4e27d into mui:v5.x Dec 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material PR: out-of-date The pull request has merge conflicts and can't be merged regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants