-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored overriding inline styles #566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded new styling function and tested it with checkbox.
…t style functions into a main style function called getStyles.
…), DropDownMenu (underline was not displaying), and Snackbar (would dismiss immediately after show).
styles.hint.opacity = 0; | ||
} | ||
|
||
if (this.props.floatingLabelText) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmrtnz
added a commit
that referenced
this pull request
Apr 24, 2015
Refactored overriding inline styles
zannager
added
the
package: styles
Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
label
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: styles
Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getStyles()
. This change was done to improve readability. Here is an example of what I mean:Extend
ThemeManager's
merge function.