Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize UI components: Toggle. #855

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Customize UI components: Toggle. #855

merged 1 commit into from
Jun 16, 2015

Conversation

misha-panyushkin
Copy link
Contributor

This update targeted on UI components customization with developers styles.

@hai-cea
Copy link
Member

hai-cea commented Jun 15, 2015

@misha-panyushkin Looks like this PR made the track too long?

This PR:
fireshot capture - material ui - http___localhost_3000_ _components_switches

Current on material-ui.com
fireshot capture - material ui - material design rea_ - http___material-ui com_ _components_switches

@misha-panyushkin
Copy link
Contributor Author

@hai-cea you're right. Restore default toggle element width in the latest commit.

hai-cea
hai-cea reviewed Jun 15, 2015
View reviewed changes
src/toggle.jsx
@@ -13,7 +13,7 @@ var Toggle = React.createClass({
},

propTypes: {
elementStyle: React.PropTypes.object,
toggleElementBoxStyle: React.PropTypes.object,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prop rename will introduce a breaking change. Can we keep as is for now pls?

@hai-cea
Copy link
Member

hai-cea commented Jun 15, 2015

Also, please squash down to 1 commit. Thanks!

@misha-panyushkin
Copy link
Contributor Author

@hai-cea sure, I'll make the PR changes tomorrow morning.

@misha-panyushkin
Toggle:
2b4d95d 
- customize toggle element width along with track width;
- update thumb switched on/off position styles with more flexible ones;
- customize toggle ripple styles;
- restore default toggle element width;
- restore breaking change in namespacing.
@misha-panyushkin
Copy link
Contributor Author

@hai-cea done.

@hai-cea
Copy link
Member

hai-cea commented Jun 16, 2015

Thanks @misha-panyushkin

hai-cea pushed a commit that referenced this pull request Jun 16, 2015
Merge pull request #855 from misha-panyushkin/MUI-Customization
239ad0c 
Customize UI components: Toggle.
@hai-cea hai-cea merged commit 239ad0c into mui:master Jun 16, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@TrySound @dmtrKovalenko
Migrate from classnames to nicer clsx (mui#855)
25571bf 
* Migrate from classnames to nicer clsx

* Update size snapshot
@akashmitra akashmitra mentioned this pull request Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@hzhz hzhz mentioned this pull request Nov 5, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Nov 5, 2022
Open
@akashmitra akashmitra mentioned this pull request Dec 25, 2022
Open
@maniator maniator mentioned this pull request Dec 26, 2022
Open
@hzhz hzhz mentioned this pull request Dec 26, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Dec 26, 2022
Open
@zannager zannager added the component: toggle button This is the name of the generic UI component, not the React module! label Mar 15, 2023
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2023
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misha-panyushkin @hai-cea @zannager