Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix print export failure when hideFooter option is set #13034

Merged
merged 3 commits into from
Jun 26, 2024
Merged

[DataGrid] Fix print export failure when hideFooter option is set #13034

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d241433
[Data Grid]fix:set style only if querySelector returns an element
tarunrajput May 6, 2024
82b1a50
Add condition
MBilalShafi Jun 22, 2024
01652a4
Merge branch 'master' into fix/usePrintGridExport
MBilalShafi Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/x-data-grid/src/hooks/features/export/useGridPrintExport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,15 +177,18 @@ export const useGridPrintExport = (
// The height above does not include grid border width, so we need to exclude it
gridClone.style.boxSizing = 'content-box';

// the footer is always being placed at the bottom of the page as if all rows are exported
// so if getRowsToExport is being used to only export a subset of rows then we need to
// adjust the footer position to be correctly placed at the bottom of the grid
const gridFooterElement: HTMLElement | null = gridClone.querySelector(
`.${gridClasses.footerContainer}`,
);
gridFooterElement!.style.position = 'absolute';
gridFooterElement!.style.width = '100%';
gridFooterElement!.style.top = `${computedTotalHeight - gridFooterElementHeight}px`;
if (!normalizeOptions.hideFooter) {
// the footer is always being placed at the bottom of the page as if all rows are exported
// so if getRowsToExport is being used to only export a subset of rows then we need to
// adjust the footer position to be correctly placed at the bottom of the grid
const gridFooterElement: HTMLElement | null = gridClone.querySelector(
`.${gridClasses.footerContainer}`,
)!;

gridFooterElement.style.position = 'absolute';
gridFooterElement.style.width = '100%';
gridFooterElement.style.top = `${computedTotalHeight - gridFooterElementHeight}px`;
}

// printDoc.body.appendChild(gridClone); should be enough but a clone isolation bug in Safari
// prevents us to do it
Expand Down