[DataGrid] Fix pagination when pagination={undefined}

[sai6855]

closes: #13330

preview: https://deploy-preview-13349--material-ui-x.netlify.app/x/react-data-grid/pagination/

check this #13349 (comment) dicussion for more context on implementaion of logic

after applying fix:

• I have followed (at least) the PR section of the contributing guide.

[mui-bot]

Deploy preview: https://deploy-preview-13349--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 63f3a7c

[sai6855]

when pagination={undefined} is set, pagintionMode key will be present in themedProps and overrides paginationMode from DATA_GRID_PROPS_DEFAULT_VALUES but when pagination prop is not explicitly passed, then value of paginationMode from DATA_GRID_PROPS_DEFAULT_VALUES will be considered since themedProps won't have paginationMode key.

With below change, both not passing pagintionMode and setting pagintionMode={undefined} will behave same

paginationMode: themedProps.paginationMode ?? DATA_GRID_PROPS_DEFAULT_VALUES.paginationMode

[flaviendelangle]

This won't solve the problem for other props so I'm not sure it's the right way of doing it 😬

[sai6855]

I see, what do you think of below approach

  const injectDefaultProps = React.useMemo(() => {
    return Object.keys(DATA_GRID_PROPS_DEFAULT_VALUES).reduce((acc, key) => {
      acc[key] =
        themedProps[key as keyof DataGridProps<R>] ??
        DATA_GRID_PROPS_DEFAULT_VALUES[key as keyof DataGridPropsWithDefaultValues<any>];
      return acc;
    }, {} as DataGridPropsWithDefaultValues<any>);
  }, [themedProps]);

  return React.useMemo<DataGridProcessedProps<R>>(
    () => ({
-      ...DATA_GRID_PROPS_DEFAULT_VALUES,
      ...themedProps,
+     ...injectDefaultProps,
      localeText,
      slots,
      ...DATA_GRID_FORCED_PROPS,
    }),
    [themedProps, localeText, slots, injectDefaultProps],
  );

[flaviendelangle]

Yeah we probably need something like that
I'll let the team working on the grid review the exact implementation.

By the way I wouldn't be surprised if we had similar issues on other packages such as @mui/x-date-pickers, I'll have a look once we settle on something here.

[Janpot]

Reminds me a bit of lodash defaults as well. A utility we could take inspiration from?

[sai6855]

refactored logic from just fixing paginationMode={undefined} to fixing all defaultProps. commit: a7f4bea