Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add react-next workflow in CircleCI #13360

Merged
merged 26 commits into from
Jul 2, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jun 3, 2024

Allows running MUI X tests against various React versions.

I've added a new react-next workflow that won't run unless approved manually in CircleCI - see https://github.com/cherniavskii/mui-x/blob/react-19-in-CI/test/README.md#next-version

@cherniavskii cherniavskii added test core Infrastructure work going on behind the scenes labels Jun 3, 2024
@mui-bot
Copy link

mui-bot commented Jun 3, 2024

Deploy preview: https://deploy-preview-13360--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f5689b7

This was referenced Jun 3, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 4, 2024

This comment was marked as outdated.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jun 4, 2024

This comment was marked as outdated.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2024

This comment was marked as outdated.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2024

This comment was marked as outdated.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 17, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 25, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 25, 2024
@cherniavskii cherniavskii marked this pull request as ready for review June 25, 2024 20:48
@cherniavskii cherniavskii requested review from a team June 25, 2024 20:54
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice effort! 👏
Leaving a few notes.
Also, there seems to be an issue with one test on react-19.

.circleci/config.yml Outdated Show resolved Hide resolved
'@mnajdova/enzyme-adapter-react-18': 'npm:@eps1lon/enzyme-adapter-react-17',
'@testing-library/react': '^12.1.0',
},
19: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only this entry that warranted the need to duplicate this file instead of using the one from monorepo? 🤔
Is it necessary though? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's one of the reasons.
Another one was that I wasn't sure if the workspace root would be resolved correctly if using the file from the monorepo: https://github.com/mui/material-ui/blob/f993fe56f59d80c9b255c0585b6b428689dfea18/scripts/useReactVersion.mjs#L15
I'll give it a try

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one was that I wasn't sure if the workspace root would be resolved correctly if using the file from the monorepo: https://github.com/mui/material-ui/blob/f993fe56f59d80c9b255c0585b6b428689dfea18/scripts/useReactVersion.mjs#L15

That script will definitely return the monorepo root.
That was the main reason why the yarn deduplicate script didn't work on mui-x. 🙈
https://github.com/mui/material-ui/blob/v5.13.5/scripts/deduplicate.mjs

scripts/useReactVersion.mjs Outdated Show resolved Hide resolved
@cherniavskii cherniavskii merged commit 13403cd into mui:master Jul 2, 2024
16 of 19 checks passed
@cherniavskii cherniavskii deleted the react-19-in-CI branch July 2, 2024 19:33
@cherniavskii cherniavskii changed the title [core] Add react_next workflow in CircleCI [core] Add react-next workflow in CircleCI Jul 2, 2024
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Co-authored-by: Lukas <llukas.tyla@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants