Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add renderHeader recipe to the Master Details docs #13370

Merged
merged 15 commits into from
Jun 7, 2024
Merged

[docs] Add renderHeader recipe to the Master Details docs #13370

merged 15 commits into from
Jun 7, 2024

Conversation

michelengelen
Copy link
Member

Fixes #12320

@michelengelen michelengelen added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! feature: Master-detail Related to the data grid Master-detail feature labels Jun 4, 2024
@michelengelen michelengelen self-assigned this Jun 4, 2024
@mui-bot
Copy link

mui-bot commented Jun 4, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13370--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against cf4eb26

@cherniavskii cherniavskii changed the title [docs] added a renderHeader example the Master Details docs [docs] Add renderHeader recipe to the Master Details docs Jun 5, 2024
michelengelen and others added 5 commits June 5, 2024 20:50
@michelengelen
make linter happy
e61ca5b
@michelengelen @cherniavskii
Update docs/data/data-grid/master-detail/master-detail.md
0639aac 
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@michelengelen
switched the method to get all row ids
8c714f8
@michelengelen
Merge remote-tracking branch 'origin/datagrid/recipes/12320' into dat…
2994865 
…agrid/recipes/12320
@michelengelen
another prop found! :D
01640fa
@michelengelen
Copy link
Member Author

@samuelsycamore could you also review the texts please? 🙇

samuelsycamore
samuelsycamore reviewed Jun 6, 2024
View reviewed changes
docs/data/data-grid/master-detail/master-detail.md Outdated Show resolved Hide resolved
docs/data/data-grid/master-detail/master-detail.md Outdated Show resolved Hide resolved
docs/data/data-grid/master-detail/master-detail.md Outdated Show resolved Hide resolved
docs/data/data-grid/row-recipes/row-recipes.md Outdated Show resolved Hide resolved
docs/data/data-grid/row-recipes/row-recipes.md Outdated Show resolved Hide resolved
docs/data/data-grid/row-recipes/row-recipes.md Outdated Show resolved Hide resolved
docs/data/data-grid/row-recipes/row-recipes.md Outdated Show resolved Hide resolved
@michelengelen @samuelsycamore
Apply suggestions from code review
8c7e198 
Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@michelengelen michelengelen merged commit ba8d2f2 into mui:master Jun 7, 2024
17 checks passed
@michelengelen michelengelen deleted the datagrid/recipes/12320 branch June 7, 2024 17:50
This was referenced Jul 12, 2024
Merged
Merged
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@michelengelen @cherniavskii
@samuelsycamore @DungTiger
[docs] Add renderHeader recipe to the Master Details docs (mui#13370)
bb0f425 
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@michelengelen @cherniavskii
@samuelsycamore @thomasmoon
[docs] Add renderHeader recipe to the Master Details docs (mui#13370)
6e1dcd9 
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Co-authored-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees

@michelengelen michelengelen

Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation feature: Master-detail Related to the data grid Master-detail feature recipe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] render custom header for detail toggle column
4 participants
@michelengelen @mui-bot @cherniavskii @samuelsycamore