Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify Pickers clearable behavior not working on mobile #13786

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[docs] Clarify Pickers clearable behavior not working on mobile #13786

merged 2 commits into from
Jul 12, 2024

Conversation

lnhrdt
Copy link
Contributor

@lnhrdt lnhrdt commented Jul 10, 2024

The clearable behavior of date picker was not tested and not implemented for mobile. This PR updates the docs to clarify that only desktop, not mobile date picker variants are supported.

Authored-by: Leonhardt Koepsell <hello@lnhrdt.com>
@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Jul 10, 2024
@LukasTy LukasTy added the docs Improvements or additions to the documentation label Jul 12, 2024
@LukasTy LukasTy changed the title Clarify date picker clearable behavior does not work on mobile [docs] Clarify Pickers clearable behavior not working on mobile Jul 12, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏
I took the liberty to update the page by improving the clarity and visibility a bit.
I also removed the reference to DesktopDate as the clearable is supported in much more places. It currently doesn't work only on MultiInput range fields and all Mobile Pickers.
What do you think? 🤔

@mui-bot
Copy link

mui-bot commented Jul 12, 2024

@lnhrdt
Copy link
Contributor Author

lnhrdt commented Jul 12, 2024

I think it's great @LukasTy, it's very easy to understand! Thanks for reviewing and for helping tighten it up even more.

@LukasTy LukasTy merged commit ee1ce3e into mui:master Jul 12, 2024
17 checks passed
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants