[docs] Use Netflix financial results to document bar charts #13991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
docs
|
Deploy preview: https://deploy-preview-13991--material-ui-x.netlify.app/ |
alexfauquette
force-pushed
the
bar-dataset
branch
from
458cf99
to
a272ad4
Compare
JCQuintas
reviewed
Aug 2, 2024
| { dataKey: 'treas', stack: 'equity' }, | ||
| ])} | ||
| xAxis={[{ scaleType: 'band', dataKey: 'year' }]} | ||
| slotProps={{ legend: { hidden: true } }} |
There was a problem hiding this comment.
Do we need to remove it? Seems like it could be helpful for the user to understand how the charts work 🤔
There was a problem hiding this comment.
The legend started to take too much space compared to the feature to display
JCQuintas
approved these changes
Aug 2, 2024
alexfauquette
commented
Aug 13, 2024
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
CodSpeed Performance ReportMerging #13991 will not alter performanceComparing Summary
|
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took Netflix financial results from Yahoo Finance and used it to illustrate bar chart staking. The underlying idea is that financial data are composed of sub-data. For example, assets are divided into short-term and long-term ones, which is well suited for staked bars.
But I'm uncertain this helps to make the docs more appealing and do not disturb the learning aspect
https://deploy-preview-13991--material-ui-x.netlify.app/x/react-charts/bars/#bar-size
https://deploy-preview-13991--material-ui-x.netlify.app/x/react-charts/bars/#stacking