Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Reduce options usage in feature hooks #2275

Merged
merged 8 commits into from
Aug 10, 2021

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Aug 2, 2021

I'm doing this migration in several steps to avoid large PRs 👍

  • Stop using options in useGridKeyboardNavigation
  • Stop using options in useGridEditRows (needed to run the useEffect that update the state from the prop after the control registration, its done that way in the other hooks)
  • Stop using options in useGridRows
  • Stop using options in useGridComponents
  • Stop using options in useErrorHandler
  • Stop using options in useLogger

I'm removing the prop decomposition in the parameters to follow #6
And because it make it obvious that we are accessing the props and not the state for cases where both make sense.

Part of #2292

@flaviendelangle flaviendelangle self-assigned this Aug 2, 2021
@oliviertassinari oliviertassinari added this to the Sprint 20 milestone Aug 2, 2021
@flaviendelangle flaviendelangle requested review from oliviertassinari, m4theushw and DanailH and removed request for oliviertassinari August 4, 2021 07:37
@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Aug 4, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like a good step forward

@flaviendelangle flaviendelangle merged commit 9770076 into mui:master Aug 10, 2021
@flaviendelangle flaviendelangle deleted the options-removal branch August 10, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants