-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Reduce options usage in feature hooks #2275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
requested review from
oliviertassinari,
m4theushw and
DanailH
and removed request for
oliviertassinari
August 4, 2021 07:37
DanailH
reviewed
Aug 4, 2021
packages/grid/_modules_/grid/hooks/features/keyboard/useGridKeyboardNavigation.ts
Show resolved
Hide resolved
DanailH
reviewed
Aug 4, 2021
DanailH
reviewed
Aug 4, 2021
DanailH
reviewed
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like a good step forward
packages/grid/_modules_/grid/hooks/features/rows/useGridEditRows.ts
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing this migration in several steps to avoid large PRs 👍
options
inuseGridKeyboardNavigation
options
inuseGridEditRows
(needed to run theuseEffect
that update the state from the prop after the control registration, its done that way in the other hooks)options
inuseGridRows
options
inuseGridComponents
options
inuseErrorHandler
options
inuseLogger
I'm removing the prop decomposition in the parameters to follow #6
And because it make it obvious that we are accessing the props and not the state for cases where both make sense.
Part of #2292