[core] Continue eslint sync with main repo #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eslintrc.js
Outdated
Comment on lines
87
to
91
| // TODO | ||
| 'react/prop-types': 'off', // For public API | ||
| 'import/prefer-default-export': 'warn', | ||
| 'react-hooks/exhaustive-deps': 'warn', | ||
| 'react-hooks/rules-of-hooks': 'warn', |
There was a problem hiding this comment.
The only diff with the eslint config in the main repository
oliviertassinari
force-pushed
the
eslint-core
branch
from
dd02ea6 to
3bf3ca1
Compare
oliviertassinari
force-pushed
the
eslint-core
branch
from
484c57e to
e33c8e1
Compare
dtassone
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #60, #6 and mui/material-ui#21758.
I turned a couple of rules as "warn" as I didn't want to handle them now. We can take care of them progressively.
It's important to tackle the problem early on before it grows to something unmanageable.
Same as mui/material-ui-pickers#2004