Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter cargo audit (deny warnings) #4322

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Stricter cargo audit (deny warnings) #4322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ffe904
Deny warnings in `cargo audit` CI job
faern Jan 31, 2023
3ae421a
Upgrade bumpalo dependency to avoid RUSTSEC-2022-0078
faern Jan 31, 2023
b5eb4ae
Upgrade env_logger to 0.10.0
faern Jan 31, 2023
2879eb3
Disable default features of quickcheck to get rid of env_logger
faern Feb 1, 2023
1590d71
Update cargo audit CI job description to not mention env_logger
faern Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/cargo-audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@ jobs:
- name: Audit
# RUSTSEC-2020-0071: Ignore the time segfault CVE since there are no known
# good workarounds, and we want logs etc to be in local time.
#
# RUSTSEC-2021-0145: The vulnerability affects custom global allocators,
# so it should be safe to ignore it. Stop ignoring the warning once
# atty has been replaced in clap and env_logger:
# atty has been replaced in clap (when we upgrade to clap 4):
# https://github.com/clap-rs/clap/pull/4249
# https://github.com/rust-cli/env_logger/pull/246
run: cargo audit --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2021-0145
run: |
cargo audit --deny warnings \
--ignore RUSTSEC-2020-0071 \
--ignore RUSTSEC-2021-0145
83 changes: 66 additions & 17 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mullvad-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ base64 = "0.13"
chrono = { version = "0.4.19", features = ["serde"] }
clap = { version = "3.0", features = ["cargo"] }
err-derive = "0.3.1"
env_logger = "0.8.2"
env_logger = "0.10.0"
futures = "0.3"
natord = "1.0.9"
serde = "1.0"
Expand Down
2 changes: 1 addition & 1 deletion mullvad-problem-report/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ talpid-platform-metadata = { path = "../talpid-platform-metadata" }

[target.'cfg(not(target_os="android"))'.dependencies]
clap = { version = "3.0", features = ["cargo"] }
env_logger = "0.8.2"
env_logger = "0.10.0"

[target.'cfg(target_os = "android")'.dependencies]
duct = "0.13"
Expand Down
2 changes: 1 addition & 1 deletion mullvad-setup/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ path = "src/main.rs"

[dependencies]
clap = { version = "3.0", features = ["cargo"] }
env_logger = "0.8.2"
env_logger = "0.10.0"
err-derive = "0.3.1"
lazy_static = "1.1.0"

Expand Down
2 changes: 1 addition & 1 deletion talpid-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,6 @@ tonic-build = { version = "0.8", default-features = false, features = ["transpor

[dev-dependencies]
tempfile = "3.0"
quickcheck = "1.0"
quickcheck = { version = "1.0", default-features = false }
quickcheck_macros = "1.0"
tokio = { version = "1", features = [ "test-util" ] }
2 changes: 1 addition & 1 deletion talpid-openvpn-plugin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ crate-type = ["cdylib"]
[dependencies]
err-derive = "0.3.1"
log = "0.4"
env_logger = "0.8.2"
env_logger = "0.10.0"
parity-tokio-ipc = "0.9"
tokio = { version = "1.8", features = ["rt"] }

Expand Down