Upgrade trust-dns-server to 0.22.0 #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkisemils
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Have not tested but the changes look sane to me.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Main motivation is to get rid of env_logger 0.9 from dependency tree
faern
force-pushed
the
upgrade-trust-dns-server
branch
from
3b2a9cc to
85580e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation is to get rid of env_logger 0.9 from dependency tree (which in turn removes yet another user of the unmaintained
attycrate that has a CVE on it).Another motivation is of course to get rid of
alphasoftware in our dependency tree.I have not yet tested this except making sure CI passes. I'll build a macOS installer and try it out.
This change is