Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR changes. Why this is wanted. And, if needed, how it does it.
Git checklist:
CHANGELOG.md
under the[Unreleased]
header.This PR fixes the misplaced gray line rendered above the app window on macOS. The upgrade to Electron 4.2.3 was necessary due to some PRs that landed in the release and made it possible to workaround the issue.
v2019.4:
this patch:
Please make sure that you can quit the app by clicking the "quit" button in Settings, this is due to some internal workarounds that temporarily make window non-closable to be able to hide the traffic lights in titlebar.
Closes #541
This change is