Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gray line defect #894

Merged
merged 1 commit into from
May 31, 2019
Merged

Fix gray line defect #894

merged 1 commit into from
May 31, 2019

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented May 31, 2019

Describe what this PR changes. Why this is wanted. And, if needed, how it does it.

Git checklist:

This PR fixes the misplaced gray line rendered above the app window on macOS. The upgrade to Electron 4.2.3 was necessary due to some PRs that landed in the release and made it possible to workaround the issue.

v2019.4:

Screenshot 2019-05-31 at 14 51 40

this patch:
Screenshot 2019-05-31 at 14 50 58

Please make sure that you can quit the app by clicking the "quit" button in Settings, this is due to some internal workarounds that temporarily make window non-closable to be able to hide the traffic lights in titlebar.

Closes #541


This change is Reviewable

@pronebird pronebird requested review from jvff and pinkisemils May 31, 2019 12:58
Copy link
Contributor

@jvff jvff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Tested here and the line is gone and the Quit button still works as expected :)

Reviewed 4 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@pronebird pronebird merged commit 8329677 into master May 31, 2019
@pronebird pronebird deleted the fix-gray-line branch May 31, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position of Grey Outline seems to be off
2 participants