Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
unix
as a "path protocol"Path Protocols are terminal protocols, similar to varint length
protocols (such as ipfs), but which in this case want to preserve
string addresses with
/
(slashes) in them. Such multiaddrs looklike this:
It can also be used for websockets, http, and more.
I'm not yet convinced this is the right way to deal with path protocols
because they force the multiaddr to be terminal (i.e. no more addrs can
be added after). Eg these would be ambiguous, so they're defined to be
part of the path protocol