Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unix path protocol #31

Merged
merged 1 commit into from
Sep 19, 2016
Merged

added unix path protocol #31

merged 1 commit into from
Sep 19, 2016

Conversation

jbenet
Copy link
Member

@jbenet jbenet commented Sep 12, 2016

This PR:

  • introduces the concept of a "path protocol"
  • adds unix as a "path protocol"

Path Protocols are terminal protocols, similar to varint length
protocols (such as ipfs), but which in this case want to preserve
string addresses with / (slashes) in them. Such multiaddrs look
like this:

/unix/stdio
/unix/foo/bar/baz.sock
/ip4/1.2.3.4/tcp/1234/unix/foo.sock
/ip4/1.2.3.4/tcp/80/ws/a/b/c

It can also be used for websockets, http, and more.

I'm not yet convinced this is the right way to deal with path protocols
because they force the multiaddr to be terminal (i.e. no more addrs can
be added after). Eg these would be ambiguous, so they're defined to be
part of the path protocol

/unix/a/b/c/ip4/1.2.3.4/tcp/8080
# this means a "unix" addr with path "/a/b/c/ip4/1.2.3.4/tcp/8080"
# NOT: a "unix" addr with path "/a/b/c", then an ip and tcp addrs.

@ghost
Copy link

ghost commented Sep 12, 2016

I think it makes sense to be able to address unix sockets. But are there any socket options that we might need to add too?

@jbenet
Copy link
Member Author

jbenet commented Sep 12, 2016

Good question. not sure.

@jbenet
Copy link
Member Author

jbenet commented Sep 19, 2016

I'm going to merge this because i'm using it in gtihub.com/multiformats/ma-pipe and it's a pain to deal with all the versions and merges. please consider /unix experimental and subject to change.

@jbenet jbenet merged commit 9aa717b into master Sep 19, 2016
@jbenet jbenet deleted the unix branch September 19, 2016 03:11
@ghost ghost mentioned this pull request Jan 17, 2017
Stebalien pushed a commit that referenced this pull request May 20, 2020
Added UDP datagram packet connection support.
marten-seemann pushed a commit to marten-seemann/go-multiaddr that referenced this pull request Feb 25, 2021
…github.com/onsi/gomega-1.7.1

Bump github.com/onsi/gomega from 1.5.0 to 1.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant