Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add two filecoin hashes, without Sum() implementations #128

Merged
merged 1 commit into from
May 12, 2020

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 12, 2020

  • sha2-256-trunc254-padded
  • poseidon-bls12_381-a2-fc1

Ref: multiformats/multicodec#161
Ref: multiformats/multicodec#171
Ref: multiformats/multicodec#170

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test to make sure this doesn't crash?

@rvagg
Copy link
Member Author

rvagg commented May 12, 2020

@Stebalien there's a couple of entries in testTable for these, got a suggestion for what else I should add to exercise it?

@Stebalien
Copy link
Member

Hm. Looking a the implementation, there's no way this is a problem.

@Stebalien
Copy link
Member

#129

@Stebalien Stebalien merged commit 62f4ba0 into multiformats:master May 12, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants