use faster sha256 and blake2b implementations #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/fast-hash
branch
2 times, most recently
from
250e661
to
db7fbde
Compare
ghost
reviewed
Dec 17, 2017
sum.go
Outdated
| } | ||
| hasher.Write(data) | ||
| var out [blake2b384Size]byte | ||
| copy(out[:], hasher.Sum(nil)[:blake2b384Size]) |
There was a problem hiding this comment.
Why the reslice of the destination here?
There was a problem hiding this comment.
I was worried that the hasher would over allocate. However, this turns out to not be the case so I'll correct it.
ghost
approved these changes
Dec 17, 2017
Could you fill out the |
Stebalien
force-pushed
the
feat/fast-hash
branch
from
db7fbde
to
eddd14f
Compare
Done. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #61