fix UDP code

[Stebalien]

fixes #72

[richardschneider]

Why has the code changed from 17 to 273? Isn't this a major breaking change.

[Stebalien]

This was a breaking change but the actual change happened in multiformats/multicodec#16. Unfortunately, the change was never propagated to js-multiaddr (or multiformats/multiaddr...). However, go-multiaddr was updated.

[dignifiedquire]

lgtm in general, no idea why CI is entirely broken

[vmx]

I agree that this is a breaking change. That information should be part of the commit message so that it ends up in the changelog (see the JS Coding Guidelines for more information).

Possible commit message:

fix: change UDP code

BREAKING CHANGE: The UDP code was changed in the multicodec table

The UDP code is now `273` instead of `17`. For the full discussion of this change
please see https://github.com/multiformats/multicodec/pull/16.

Fixes #17.

[daviddias]

Adding a ping to @victorb to review as the Lead Maintainer of this module -- https://github.com/multiformats/js-multiaddr#lead-maintainer

Thanks for reviewing and pointing to the Contributing guidelines as a source on how to complete this PR, @vmx 👏🏽👏🏽👏🏽

[victorb]

CI is failing here as the test-cases haven't been updated. See the failures here: https://ci.ipfs.team/blue/organizations/jenkins/Multiformats%2Fjs-multiaddr/detail/PR-73/1/tests

[Stebalien]

Seriously?

49:7 warning Unexpected use of continue statement no-continue
...
341:1 warning Unexpected 'todo' comment no-warning-comments

[victorb]

Great, thanks!

[victorb]

js-multiaddr@6.0.0 has now been released!

[daviddias]

@victorb did you completely ignore @vmx's indication? #73 (comment)

[Stebalien]

@daviddias I fixed the commit message before this was merged.

[vmx]

@daviddias You have to look at the commit history and you'll find e8c3d7d, which contains the proper "breaking change" part (which also shows up in the changelog).

The GitHub message links to the merge commit, you would need to click through it's parents.

[daviddias]

I see. I looked through the commit history but I looked at @victorb commits and not @Stebalien, my bad.