Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Fix incompatibility with zii via @rvagg's fix #84

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Fix incompatibility with zii via @rvagg's fix #84

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c5296a
Fix incompatibility with zii via @rvagg's fix
KyleMaas Feb 24, 2021
1c6e1b9
Remove type casts
KyleMaas Feb 24, 2021
4fc96b2
Use Object.prototype.hasOwnProperty.call instead so that this passes …
KyleMaas Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ function validEncode (name, buf) {
* @throws {Error} Will throw if the encoding is not supported
*/
function encoding (nameOrCode) {
if (constants.names[/** @type {BaseName} */(nameOrCode)]) {
if (Object.prototype.hasOwnProperty.call(constants.names, /** @type {BaseName} */(nameOrCode))) {
return constants.names[/** @type {BaseName} */(nameOrCode)]
} else if (constants.codes[/** @type {BaseCode} */(nameOrCode)]) {
} else if (Object.prototype.hasOwnProperty.call(constants.codes, /** @type {BaseCode} */(nameOrCode))) {
return constants.codes[/** @type {BaseCode} */(nameOrCode)]
} else {
throw new Error(`Unsupported encoding: ${nameOrCode}`)
Expand Down