Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent naming and export conversion tables #73

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Consistent naming and export conversion tables #73

merged 3 commits into from
Dec 17, 2020

Commits on Dec 16, 2020

  1. refactor: rename CodecNumber to CodecCode 

    License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
    @hacdias
    hacdias committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    23322e1 View commit details
    Browse the repository at this point in the history

  2. feat: export tables and dedup code 

    License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
    @hacdias
    hacdias committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    0881314 View commit details
    Browse the repository at this point in the history

  3. refactor: rename functions to explicit names 

    Breaking refactorings:
- Renamed getCodec to getNameFromData
- Renamed getName to getNameFromCode
- Renamed getNumber to getCodeFromName
- Renamed getCode to getCodeFromData
- Renamed getCodeVarint to getVarintFromName
- Renamed getVarint to getVarintFromCode
- getVarintFromCode returns Uint8Array instead of Array

For backwards compatibility, all old names were kept as alias,
and getVarint returns a regular Array as it did before. This does
not break compatibility. They are all marked as @deprecated.

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
    @hacdias
    hacdias committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    13bbb1a View commit details
    Browse the repository at this point in the history