Fix equality check #216
Closed
Fix equality check #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangerMauve
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Duplicate of https://github.com/multiformats/js-multiformats/pull/215/files
Which one should we accept? @rvagg
|
Closing this in favor of #215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
I've looked into the issue and turns out it can only occur on CIDv0, because CIDv1 always seem to re-encode (which I think is a bug btw)
js-multiformats/src/cid.js
Line 381 in 0ec751a
js-multiformats/src/cid.js
Lines 287 to 289 in 0ec751a
Never the less this turns
byteOffsetandbyteLengthto getters so they won't be considered in equality checks.I also had to add check
digest.bytes instance Uint8Arraycheck otherwise some tests passing garbage data were no longer throwing on construction.